[openib-general] Re: [PATCH 2 of 2] ipoib: ipoib_multicast.c cleanup

[Michael S. Tsirkin]

Quoting r. Roland Dreier <rolandd at cisco.com>:
> Subject: Re: [PATCH 2 of 2] ipoib: ipoib_multicast.c cleanup
> 
> I applied this bit as obviously correct:
> 
>  > 2. Make sure mcast->done is initialized to uncompleted value
>  >    before we submit a new query, so that its safe to wait on.
> 
> but I couldn't convince myself that
> 
>  > 1. Make sure mcast->query is set to NULL if, and only if,
>  >    no query is outstanding.
>  > 4. Protect all accesses to priv->broadcast, priv->multicast_list,
>  >    mcast->query and mcast->done by priv->lock.
>  >    I had to change mcast_mutex to ipoib_mcast_lock to make the last bit work.
> 
> were improvements (and there was no 3. ;)
> 
>  - R.
> 

For example, mcast_restart_thread performs list walk with no locking.
Isnt this a problem?

-- 
MST