[openib-general] RE: [PATCH] Opensm - enabling erase of log file flag

[Hal Rosenstock]

On Wed, 2005-10-12 at 02:52, Yael Kalka wrote:
> You are right. Thanks!

Thanks. Applied.

-- Hal

> Yael
> 
> -----Original Message-----
> From: Hal Rosenstock [mailto:halr at voltaire.com]
> Sent: Tuesday, October 11, 2005 3:18 PM
> To: Yael Kalka
> Cc: openib-general at openib.org; Eitan Zahavi
> Subject: Re: [PATCH] Opensm - enabling erase of log file flag
> 
> 
> Hi Yael,
> 
> On Tue, 2005-10-11 at 08:24, Yael Kalka wrote:
> > Currently the osm log file is accumulative. I've added an option to
> > erase the log file before starting to write it.
> > By default, still, the log is still accumulative.
> > Attached is a patch for that.
> 
> One minor comment on this...
> 
> > Thanks,
> > Yael
> > 
> > Signed-off-by:  Yael Kalka <yael at mellanox.co.il>
> 
> > Index: opensm/osm_subnet.c
> > ===================================================================
> > --- opensm/osm_subnet.c       (revision 3704)
> > +++ opensm/osm_subnet.c       (working copy)
> 
> > @@ -920,6 +925,7 @@ osm_subn_write_conf_file(
> >      "force_log_flush %s\n\n"
> >      "# Log file to be used\n"
> >      "log_file %s\n\n" 
> > +    "accum_log_file %s\n\n"
> >      "# The directory to hold the file OpenSM dumps\n"
> >      "dump_files_dir %s\n\n"
> >      "# If TRUE if OpenSM should disable multicast support\n"
> > @@ -929,6 +935,7 @@ osm_subn_write_conf_file(
> >      p_opts->log_flags,
> >      p_opts->force_log_flush ? "TRUE" : "FALSE",
> >      p_opts->log_file,
> > +    p_opts->accum_log_file,
> 
> Shouldn't this line be:
>         p_opts->accum_log_file ? "TRUE" : "FALSE",
> 
> -- Hal
>