[openib-general] Re: [PATCH] [SA Query] Change sa_query MAD allocation

Sean Hefty mshefty at ichips.intel.com
Thu Oct 13 17:05:06 PDT 2005


Roland Dreier wrote:
> Thanks, I'll read this over.
> 
> What's the motivation here?  To shift over to ib_create_send_mad() so
> that all the MAD-related DMA mapping stuff is in one place, to make it
> easier to fix?

Yes - the motivation is to fix the DMA mapping issue that you pointed out by 
changing ib_post_send_mad() to take an ib_mad_send_buf as input.

There are three places that I see where ib_post_send_mad() is called without 
using ib_create_mad_send(): sa_query, mthca_mad, and agent.  (Their 
implementation pre-dates the call.)  My intent was to patch each of these 
separately to use ib_create_mad_send(), then apply a patch to convert the API. 
If the API does not change to take an ib_mad_send_buf, then it's your call 
whether to apply the patch.

- Sean



More information about the general mailing list