[openib-general] Re: [PATCH] [MAD/Agent] convert agent.c to use ib_create_send_mad()
Sean Hefty
mshefty at ichips.intel.com
Mon Oct 17 12:38:10 PDT 2005
Hal Rosenstock wrote:
>>The agent code now allocates a buffer for the MAD by calling
>>ib_create_send_mad(). The input MAD buffer is copied to the send buffer, then
>>transmitted. The result is that the input MAD buffer is always available for
>>posting on the receive queue.
>
> What about the other resources needed ? Are they always available ?
Not sure what you're referring to here. The changes to mad.c were very minor.
>>IMO, the print statements would be better placed in agent_send_response(), which
>> knows the context surrounding the failure, than by a caller.
>
> That's what I was suggesting (but I didn't see them in your updated
> patch).
No - I didn't add debug print statements to the code. There were only a couple
of prints in the original code. Do you want debug prints added?
- Sean
More information about the general
mailing list