[openib-general] [PATCH] Fix for MAD layer DMA mappings

Roland Dreier rolandd at cisco.com
Mon Oct 24 21:33:30 PDT 2005


Yeah, this looks fine to check in.  I have a couple of trivial
cleanups I'd like to do for sa_query.c and user_mad.c, but I can do
them after you commit.  Also, this chunk:

    > --- trunk/src/linux-kernel/infiniband/core/smi.h	(revision 3830)
    > +++ trunk/src/linux-kernel/infiniband/core/smi.h	(working copy)
    > @@ -35,10 +35,11 @@
    >   *
    >   * $Id$
    >   */
    > -
    >  #ifndef __SMI_H_
    >  #define __SMI_H_
    > 

looks bogus -- I'd prefer to keep that blank line there, since it
looks ugly to me to have the #ifndef right after the closing */.

 - R.



More information about the general mailing list