[openib-general] Re: [PATCH] Minor mad_rmpp.c cleanup

Sean Hefty mshefty at ichips.intel.com
Tue Oct 25 15:10:09 PDT 2005


Roland Dreier wrote:
> This changes alloc_response_msg() in mad_rmpp.c to return the struct
> it allocates directly (or an error code a la ERR_PTR), rather than
> returning a status and passing the struct back in a pointer param.
> This simplifies the code and gets rid of warnings like
> 
>     drivers/infiniband/core/mad_rmpp.c: In function nack_recv:
>     drivers/infiniband/core/mad_rmpp.c:192: warning: msg may be used uninitialized in this function
> 
> with newer versions of gcc.

Thanks!  Committed.

- Sean



More information about the general mailing list