[openib-general] Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator

[Christoph Hellwig]

On Mon, Oct 31, 2005 at 09:03:35PM -0800, Roland Dreier wrote:
>     Christoph> No. Bitfields for accessing hardware/wire
>     Christoph> datastructures are wrong and will always break in some
>     Christoph> circumstances.  Your header is much better.
> 
> OK, that's my feeling as well.
> 
> Would it make sense for me to split the pure SRP spec structures and
> so on into a separate file and put it in include/scsi/srp.h?  Then we
> can move ibmvscsi towards using that file.

Sounds like a good idea, yes.