[openib-general] Re: at won't compile with gcc-2.95

[James Lentini]

On Thu, 1 Sep 2005, Roland Dreier wrote:

>     > Not sure yet on what gcc 2.95 doesn't like about:
>     > #define WARN(fmt, arg ...)      printk("ib_at: %s: " fmt "\n", __FUNCTION__,  ## arg);
>     > but that is the cause of the other compile issue in at.c.
> 
> Probably it doesn't like the extra space in WARN(fmt, arg ...).
> Hmm... changing it to
> 
> #define WARN(fmt, arg...)	printk("ib_at: %s: " fmt "\n", __FUNCTION__, ## arg);
> 
> fixes the original complaint, but then gcc 2.95 doesn't like things like:
> 
> 			WARN("pending request not found in parent request!");
> 
> ie WARN() with no arg parameter.  Not sure how to make gcc 2.95 happy
> about that...

I think you want

#define WARN(fmt, ...) \
	printk("ib_at: %s: " fmt "\n", __FUNCTION__, __VA_ARGS__)

(note that I've removed the ";") but I don't have gcc 2.95 to test it.

Roland, out of curiosity, why are you using gcc 2.95? According to 
http://www.gnu.org/software/gcc/releases.html, it is fairly old.