[openib-general] Re: [PATCH] only build userspace verbs support if requested

[James Lentini]

On Tue, 6 Sep 2005, Roland Dreier wrote:

>     James> Are the other userspace components useful without uverbs
>     James> support? I didn't think the umad, ucm, and uat layers would
>     James> work without the uverbs.
> 
> Certainly umad is useful without uverbs.  For example one can use
> just umad to run OpenSM.  In fact umad predates uverbs by quite a long
> time.  Thanks for pointing this out -- certainly we don't want to lump
> umad and uverbs into the same config option.
> 
> ucm and uat probably aren't that useful without uverbs.
> 
> So I guess the final patch should have CONFIG_INFINIBAND_USER_MAD and
> CONFIG_INFINIBAND_USER_ACCESS as separate config options.

Here's an updated. Note that I did not modify the 
INFINIBAND_USER_ACCESS option's help text. In particular, it is still 
described as "InfiniBand userspace verbs support" and not "InfiniBand 
userspace access support" since I find the former more descriptive of 
what is being enabled than the later.

Signed-off-by: James Lentini <jlentini at netapp.com>

Index: Kconfig
===================================================================
--- Kconfig	(revision 3326)
+++ Kconfig	(working copy)
@@ -7,7 +7,16 @@
 	  any protocols you wish to use as well as drivers for your
 	  InfiniBand hardware.
 
-config INFINIBAND_USER_VERBS
+config INFINIBAND_USER_MAD
+	tristate "InfiniBand userspace MAD support"
+	depends on INFINIBAND
+	---help---
+	  Userspace InfiniBand Management Datagram (MAD) support.  This
+	  is the kernel side of the userspace MAD support, which allows
+	  userspace processes to send and receive MADs. You will also 
+	  need libibumad from <http://www.openib.org>.
+
+config INFINIBAND_USER_ACCESS
 	tristate "InfiniBand userspace verbs support"
 	depends on INFINIBAND
 	---help---
Index: core/Makefile
===================================================================
--- core/Makefile	(revision 3326)
+++ core/Makefile	(working copy)
@@ -1,9 +1,9 @@
 EXTRA_CFLAGS += -Idrivers/infiniband/include -Idrivers/infiniband/ulp/ipoib
 
-obj-$(CONFIG_INFINIBAND) +=		ib_core.o ib_mad.o ib_ping.o \
-					ib_cm.o ib_sa.o ib_umad.o ib_ucm.o \
-					ib_at.o ib_uat.o
-obj-$(CONFIG_INFINIBAND_USER_VERBS) +=	ib_uverbs.o
+obj-$(CONFIG_INFINIBAND) +=		ib_core.o ib_mad.o ib_ping.o ib_cm.o \
+					ib_sa.o ib_at.o
+obj-$(CONFIG_INFINIBAND_USER_MAD) += 	ib_umad.o
+obj-$(CONFIG_INFINIBAND_USER_ACCESS) += ib_uverbs.o ib_ucm.o ib_uat.o
 
 ib_core-y :=			packer.o ud_header.o verbs.o sysfs.o \
 				device.o fmr_pool.o cache.o