[openib-general] Re: Re: [PATCH] [CM] 3/6 SDP updates to bind cm_id's to a device

Michael S. Tsirkin mst at mellanox.co.il
Wed Sep 7 10:22:30 PDT 2005


Quoting Sean Hefty <mshefty at ichips.intel.com>:
> >At least, this warrants a comment in the header file.
> 
> In ib_cm.h:
> 
> 	enum ib_cm_state	state;		/* internal CM/debug use */
> 	enum ib_cm_lap_state	lap_state;	/* internal CM/debug use */

Doh. Should have checked my facts better before posting.

[...]
> I believe that once SDP is fixed, these can be moved into the internal 
> structure to avoid this issue in the future.

I agree. In fact, if you post a separate patch for just the cm state
I'm ready to apply that right away.

Thanks,

-- 
MST



More information about the general mailing list