[openib-general] Re: sdp: kill sdp buff pool

[Tom Duffy]

On Sep 8, 2005, at 4:41 AM, Michael S. Tsirkin wrote:


> SDP seems to have a re-implementation of kmem_cache in sdp_buff.
> Killing it actually results in a small bandwidth increase
> for both bcopy and zcopy versions, so I plan to put this in.
>

Can you please post some numbers?


> Note that sdp_buff_pool_chain_link is now same as sdp_buff_pool_put,
> and sdp_buff_pool_chain_put is now a nop, but I decided to
> keep it in for now, just in case there's another use for it.
>

like what?


>  sdp_buff.c  |  388 +++++ 
> +------------------------------------------------------
>  sdp_dev.h   |    7 -
>  sdp_inet.c  |   17 --
>  sdp_proc.c  |    6
>  sdp_proc.h  |   11 -
>  sdp_proto.h |   10 -
>  6 files changed, 50 insertions(+), 389 deletions(-)
>

I love patches like this.  Much better than what I had done ;)

-tduffy