[openib-general] Re: Some OpenSM 1.8.0 Anomalies

Eitan Zahavi eitan at mellanox.co.il
Sat Sep 10 00:24:41 PDT 2005


Hal Rosenstock wrote:
> On Fri, 2005-09-09 at 16:14, Eitan Zahavi wrote:
> 
>>>I think the comment in the code is wrong here and should be gid
>>
>>rather
>>
>>>than pkey. I do agree that the pkey sharing needs checking but that
>>
>>is
>>
>>>separate.
>>
>>[EZ] OK we can improve the comments accuracy and readability. As
>>always comments written by the developers are somewhat biased by the
>>fact he already understands the code. So the first time reader can do
>>a better job...
> 
> 
> Understood.
> 
> 
>>>I'm still not sure what is the bug you are referring to above
>>
>>though.
>>[EZ] The bug is that the code does not perform the required operations
>>to meet o13-17.1.2 compliancy.
> 
> 
> What is missing ? Is it the part relating to "except if
> InformInfo:LIDRangeBegin was 0xFFFF" ?
Ooops. I was the one to coded it but still forgot. Yes you are right -
everything is already there.

> 
> -- Hal




More information about the general mailing list