[openib-general] Re: sdp: kill sdp buff pool
Michael S. Tsirkin
mst at mellanox.co.il
Sun Sep 11 00:22:16 PDT 2005
Quoting Tom Duffy <thomas.duffy.99 at alumni.brown.edu>:
> >Yep, simple replacing of sdp lists with list_head (mega patch that
> >I posted previously) hurts performance by some 10%, and I didnt yet
> >figure why.
>
> Which patch was that?
It turns out I didnt post that patch yet.
It might not apply cleanly now since I didnt yet update it after
recent changes. Do you want to see it?
> Did that include the sdp_buff.[ch] changes I
> posted?
No, it took a more drastic approach of replacing all calls to
sdp_buff,sdp_queue,sdp_advt and sdp_iocb functions by list.h macros.
This probably was too big a change: replacing just the list traversal
functions and the casts with list_for_each and container_of calls
would likely work better.
--
MST
More information about the general
mailing list