[openib-general][PATCH][RFC]: CMA IB implementation
Roland Dreier
rolandd at cisco.com
Mon Sep 19 09:56:22 PDT 2005
> /*
> * approximately transforms microseconds to 4.096us*2^x*
> * 63(+8) is max return
> */
> static inline u8 us_to_cmt(u32 us) {
This looks pretty bogus -- it only handles timeouts up to 2^32
microseconds, ie only 4 seconds. But fortunately...
> timeout = us_to_cmt(cma_conn->qp_attr->timeout);
the only use of it is bogus as well. You never use timeout again,
which is good because qp_attr->timeout is not in units of
microseconds; it's already in the IB logarithmic scale.
- R.
More information about the general
mailing list