[openib-general] Re: [PATCH} OpenSM osm_vendor_ibumad.c::osm_vendor_send Fix length of umad_send

Eitan Zahavi eitan at mellanox.co.il
Mon Sep 19 13:09:13 PDT 2005


Hi Hal,

Hal Rosenstock wrote:
> osm_vendor_ibumad.c::osm_vendor_send Fix length of umad_send when
> VENDOR_RMPP_SUPPORT is defined. 
> 
> NOTE: This requires the user_mad.c::ib_umad_write patch just sent.
Please send a clear message when this can be tested.
I see many mails between you and Roland and now confused when it is
going to be fully supported in the trunk core and management.

I guess this is all about the truncated RMPP send I have complained about.

Thanks for fixing it

Eitan
> 
> Signed-off-by: Hal Rosenstock <halr at voltaire.com>
> 
> Index: osm_vendor_ibumad.c
> ===================================================================
> --- osm_vendor_ibumad.c (revision 3480)
> +++ osm_vendor_ibumad.c (working copy)
> @@ -983,8 +983,12 @@ osm_vendor_send(
>                 put_madw(p_vend, p_madw, &p_mad->trans_id);
>  
>         if ((ret = umad_send(p_bind->port_id, p_bind->agent_id,
> p_vw->umad,
> +#ifdef VENDOR_RMPP_SUPPORT
> +                            p_madw->mad_size,
> +#else
>                              is_rmpp ? p_madw->mad_size -
> IB_SA_MAD_HDR_SIZE :
>                                        p_madw->mad_size,
> +#endif
>                              resp_expected ? p_vend->timeout : 0,
>                              p_vend->max_retries)) < 0) {
>                 if (resp_expected)
> 




More information about the general mailing list