[openib-general][PATCH][RFC]: CMA header

James Lentini jlentini at netapp.com
Tue Sep 20 13:58:12 PDT 2005



On Mon, 19 Sep 2005, Guy German wrote:

> enum ib_cma_event {
> 	IB_CMA_EVENT_ESTABLISHED = 1,
> 	IB_CMA_EVENT_REJECTED,
> 	IB_CMA_EVENT_NON_PEER_REJECTED,
> 	IB_CMA_EVENT_DISCONNECTED,
> 	IB_CMA_EVENT_UNREACHABLE
> };

Why not make REJECTED mean NON_PEER_REJECTED and add a PEER_REJECTED? 
In other words:

 enum ib_cma_event {
       IB_CMA_EVENT_ESTABLISHED = 1,
       IB_CMA_EVENT_REJECTED,
       IB_CMA_EVENT_PEER_REJECTED,
       IB_CMA_EVENT_DISCONNECTED,
       IB_CMA_EVENT_UNREACHABLE  
 };

In my opinion this makes the hierarchy clearer. There are general 
rejections and specific peer rejections.



More information about the general mailing list