[openib-general][PATCH][SRP] bug fixes & fmr supported,

[Christoph Hellwig]

On Tue, Sep 20, 2005 at 04:52:54PM -0700, Roland Dreier wrote:
> Thanks, I haven't read all the FMR stuff through yet, but a few quick comments:
> 
>     > + support more than default 8 luns per target. Should we have max_luns
>     > as module param? How about cmds_per_lun, max_sectors, max_targets as
>     > module params as well
> 
> I think it makes more sense to handle this the same way I handled
> max_sectors: make it a per-target parameter passed in when connecting
> to the target.  We could make cmds_per_lun a similar parameter, but
> are there likely to be any SRP targets that need this to be limited?
> Also, what is max_targets?

Why do we need a limited max_luns at all?  I hope all SRP targets
propetly support REPORT_LUNS in which case we couldn't care less about
a maximum LUN limit.  And even if they don't I hope they handle scanning
the first non-existant LUN gracefully.