[openib-general] Re: opensm and SIGINT

[Eitan Zahavi]

Hi Hal, Viswa,

Sorry I'm joining late on this thread due to the weekend (which starts here on Friday ending Saturday night).
Is there any conclusion on this one? The only log I have seen was from osmtest failing to send a MAD.
Looks like a umad issue?

Eitan

Hal Rosenstock wrote:
> Hi again Viswa,
> 
> On Wed, 2005-09-21 at 21:00, Hal Rosenstock wrote:
> 
>>Hi Viswa,
>>
>>On Wed, 2005-09-21 at 20:23, Viswanath Krishnamurthy wrote:
>>
>>>Currently opensm traps SIGINT. There was some discussion to remove
> 
> it.
> 
>>>I have currently running some tests on opensm
>>>by killing (SIGKILL) and restarting opensm. So far I ahve not found
>>>any resource leak issues. Is ther a plan to remove that
>>>signal handler. Ideally it should not exist.
>>
>>Eitan stated that this was historical in nature for gen1 drivers which
>>had resource tracking problems: "if OpenSM left without cleaning up
> 
> all
> 
>>used resources (like MAD buffers and UD-AVs), the driver oops'ed."
>>
>>I think that (eliminating the handler for SIGINT) can at least be done
>>for OSM_VENDOR_INTF_OPENIB and leave it there for the other vendor
>>layers for starters. I will experiment with gen2 and let you know.
> 
> 
> Does the patch below do what you want ? Can you try it ?
> 
> -- Hal
> 
> Index: opensm/osm_opensm.c
> ===================================================================
> --- opensm/osm_opensm.c (revision 3513)
> +++ opensm/osm_opensm.c (working copy)
> @@ -182,7 +182,9 @@ osm_reg_sig_handler(
>     IN osm_opensm_t * const p_osm )
>  {
>     __p_osm_to_signal = p_osm;
> +#ifndef OSM_VENDOR_INTF_OPENIB 
>     cl_reg_sig_hdl( SIGINT, __sig_handler );
> +#endif
>     cl_reg_sig_hdl( SIGTERM, __sig_handler );
>     cl_reg_sig_hdl( SIGHUP, __sig_handler );
>     osm_exit_flag = 0;
> 
> 
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
> 
> To unsubscribe, please visit
> http://openib.org/mailman/listinfo/openib-general
>