[openib-general] Re: [PATCH] incorrect atomic attribute returned by ib/v_query_device

[Roland Dreier]

    Jack> I'm starting to fix ib_query_device/ibv_query_device --
    Jack> adding missing fields, correcting values in current fields.

Great!

    Jack> Enclosed is a patch for the atomic_cap field.  Please
    Jack> review.  Thanks.

Thanks, applied and queued for 2.6.15, with the following fix

    > --- linux-kernel/infiniband/core/uverbs_cmd.c	(revision 3532)
    > +++ linux-kernel/infiniband/core/uverbs_cmd.c	(working copy)
    > @@ -199,6 +199,7 @@
    >  	resp.max_pkeys 		       = attr.max_pkeys;
    >  	resp.local_ca_ack_delay        = attr.local_ca_ack_delay;
    >  	resp.phys_port_cnt	       = file->device->ib_dev->phys_port_cnt;
    > +	resp.atomic_cap                = attr.atomic_cap;
    >  
    >  	if (copy_to_user((void __user *) (unsigned long) cmd.response,
    >  			 &resp, sizeof resp))

This chunk seems to introduce a duplicate line -- we already set
atomic_cap a few lines earlier.  I just left this part out.

 - R.