[openib-general] Re: [PATCH] add cq error events

Michael S. Tsirkin mst at mellanox.co.il
Tue Sep 27 10:34:33 PDT 2005


Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [openib-general] Re: [PATCH] add cq error events
> 
> Michael S. Tsirkin wrote:
> > Okay ... one problem that I've run into adding this, is
> > that IB_EVENT_CQ_ERR is the first item in the ib_event_type enum.
> > And since uverbs seems to just copy the event over to userspace,
> > changing all the enum values would break the ABI.
> > 
> > Given that IB_EVENT_CQ_ERR wasnt actually produced by any hardware
> > provider yet, I'm thinking about working around this by simply giving
> > specific values to enum items, like this
> 
> Why not keep CQ_ERR as the generic access error, and then add
> CQ_OVERRUN to the end?
> 
> - Sean
> 

Fine with me. Roland?

-- 
MST



More information about the general mailing list