[openib-general] Re: [PATCH] Opensm - accept HANDOVER during DISOVERY

Hal Rosenstock halr at voltaire.com
Wed Sep 28 05:39:18 PDT 2005


On Wed, 2005-09-28 at 07:06, Yael Kalka wrote:
> Here is a patch for the valid signaling you found.
> If we receive a HANDOVER signal during DISCOVERY it can just be
> ignored (continue the discovering).

Thanks. That made it easy but is a partial patch. In the future, please
indicate whether patches are tested or not.

Below is an updated patch for this.

-- Hal

Index: osm_sm_state_mgr.c
===================================================================
--- osm_sm_state_mgr.c	(revision 3590)
+++ osm_sm_state_mgr.c	(working copy)
@@ -587,6 +587,14 @@ osm_sm_state_mgr_process(
 
          __osm_sm_state_mgr_start_polling( p_sm_mgr );
          break;
+      case OSM_SM_SIGNAL_HANDOVER:
+        /*
+         * Do nothing. We will discover it later on. If we already discovered
+         * this SM, and got the HANDOVER - this means the remote SM is of 
+         * lower priority. In this case we will stop polling it (since it is
+         * a lower priority SM in STANDBY state).
+         */
+         break;
       default:
          __osm_sm_state_mgr_signal_error( p_sm_mgr, signal );
          status = IB_INVALID_PARAMETER;
@@ -798,6 +806,7 @@ osm_sm_state_mgr_check_legality(
       case OSM_SM_SIGNAL_DISCOVERY_COMPLETED:
       case OSM_SM_SIGNAL_MASTER_OR_HIGHER_SM_DETECTED:
       case OSM_SM_SIGNAL_MASTER_OR_HIGHER_SM_DETECTED_DONE:
+      case OSM_SM_SIGNAL_HANDOVER:
          status = IB_SUCCESS;
          break;
       default:






More information about the general mailing list