[openib-general] Re: static rate encoding change support

Roland Dreier rdreier at cisco.com
Sun Apr 2 10:43:00 PDT 2006


 > @@ -435,10 +443,16 @@ int mthca_query_qp(struct ib_qp *ibqp, s
 >  		goto out;
 >  	}
 >  
 > +	if (qp->transport == RC || qp->transport == UC)
 > +		for (i = 1; i < dev->limits.num_ports; ++i)
 > +			if ((err = mthca_update_rate(dev,i)))
 > +				goto out;

I haven't read through all of this very carefully yet, but I'm
wondering about this.  Why is it necessary to update the rates of all
the ports on every query QP call?

Any all of this seems like a whole lot of complexity for not much
value.  If we really care about returning static rate from query QP,
why not just store away the original state rate passed in through
modify QP?

 - R.



More information about the general mailing list