[openib-general] Re: SRP compile warning in Branch 1.0

[Ira Weiny]

On Sun, 05 Mar 2006 01:17:42 +0200
"Michael S. Tsirkin" <mst at mellanox.co.il> wrote:

> Quoting r. Bob Woodruff <robert.j.woodruff at intel.com>:
> > I am not sure the backport for SRP is completely correct. 
> > I have never tested it as I don't have a target or time to test it
> > right now.
> 
> An open-source gen1 based SRP target implementation can be found under
> https://openib.org/svn/trunk/contrib/mellanox/gen1/ib_srpt/
> 

We needed an SRP target and using the above and a gen1 stack supplied by
Mellanox I have gotten SRP working.  However, in response to my original post
about the compile error...

>
> /tftpboot/weiny2/openib/openib-modules/openib/infiniband/ulp/srp/ib_srp.c: In function `srp_add_target':
> /tftpboot/weiny2/openib/openib-modules/openib/infiniband/ulp/srp/ib_srp.c:1263: warning: passing arg 1 of `scsi_scan_target' from incompatible pointer type
>

I had to apply the following patch.  Indeed my initial assumption was correct.

Thanks,
Ira

===================================================================
--- openib/infiniband/ulp/srp/ib_srp.c  (revision 2070)
+++ openib/infiniband/ulp/srp/ib_srp.c  (working copy)
@@ -1259,8 +1259,7 @@
        target->state = SRP_TARGET_LIVE;
 
        /* XXX: are we supposed to have a definition of SCAN_WILD_CARD ?? */
-       scsi_scan_target(&target->scsi_host->shost_gendev,
-                        0, target->scsi_id, ~0, 0);
+       scsi_scan_target(target->scsi_host, 0, target->scsi_id, ~0, 0);
 
        return 0;
 }