[openib-general] Re: [PATCH] repost: IPoIB queue size tune patch

[Krishna Kumar2]

Shirley,

Some nits :

1. You can use :

priv->tx_ring = kzalloc(ipoib_recvq_size * sizeof *priv->rx_ring, 
GFP_KERNEL);
(for tx & rx)

instead (though this is not a change introduced by you).

2. make :

+        *else* if (ipoib_recvq_size < IPOIB_MIN_QUEUE_SIZE) {
(for sendq/recvq)

3. Error messages can be changed from (since "too big" implies cutting at 
"max", same for "too small" and "min") :

printk(KERN_WARNING "%s: ipoib_sendq_size is too big, use max %d 
instead\n", ca->name, IPOIB_MAX_QUEUE_SIZE); 

to :

printk(KERN_WARNING "%s: ipoib_sendq_size is too big, using %d instead\n", 
ca->name, IPOIB_MAX_QUEUE_SIZE); 

Thanks,

- KK