[openib-general] Re: Re: [PATCH] ipoib_flush_paths

Michael S. Tsirkin mst at mellanox.co.il
Wed Apr 5 17:36:35 PDT 2006


Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: Re: [PATCH] ipoib_flush_paths
> 
> Michael S. Tsirkin wrote:
> >The only easy way out that I see is some kind of sa_flush function that
> >will flush MAD wqs, and ask all users to call that.
> >And I think we have the same bug in addr so this needs a flush function 
> >too.
> 
> My preference would be to add a registration function to ib_sa and ib_addr. 
> Otherwise, we weaken the encapsulation between the modules, since ib_sa 
> doesn't own the threads that it uses in its callbacks.

I don't see the connection (since we only need de-register, let's just call
it flush and be done with it), but fine. Please propose an API then.

> Registration could be global, or per port.  The latter probably makes the 
> most sense.

Probably global for ib_addr, per port for ib_sa: we don't want to force
ib_addr users to deal with devices.

-- 
MST



More information about the general mailing list