[openib-general] Re: RE: Re: [PATCH] ipoib_flush_paths

[Muli Ben-Yehuda]

On Thu, Apr 06, 2006 at 04:17:55PM +0300, Michael S. Tsirkin wrote:
> Quoting r. Roland Dreier <rdreier at cisco.com>:
> > I'm pretty sure that any scheme that tries to use module reference
> > counting will either be horribly complex, still have subtle races, or
> > (mostly likely) both.
> 
> Actually, it turned out to be the simplest solution - and quite
> elegant since there's no room for mistakes: if query is going to be running
> this means module is still loaded so we can take a reference to it
> without races.

Don't you have a race between the point you make the call (pass
THIS_MODULE) and the point you __get_module on it? what's keeping the
module from disappearing between those two points?

Cheers,
Muli
-- 
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/