Same comments as the sa_query patch apply here: - __module_get() has a race, use try_module_get() instead - let's hide the THIS_MODULE inside an inline wrapper so consumers of the API don't change and don't have to think about this at all. Other than that it seems good. - R.