[openib-general] Re: [RFC] [PATCH 2/2] ipoib: convert to use new multicast interface

Roland Dreier rdreier at cisco.com
Thu Apr 6 13:05:03 PDT 2006


There is a fair amount of simple reformatting here like

 > -	comp_mask =
 > -		IB_SA_MCMEMBER_REC_MGID		|
 > -		IB_SA_MCMEMBER_REC_PORT_GID	|
 > -		IB_SA_MCMEMBER_REC_PKEY		|
 > -		IB_SA_MCMEMBER_REC_JOIN_STATE;
 > +	comp_mask = IB_SA_MCMEMBER_REC_MGID		|
 > +		    IB_SA_MCMEMBER_REC_PORT_GID		|
 > +		    IB_SA_MCMEMBER_REC_PKEY		|
 > +		    IB_SA_MCMEMBER_REC_JOIN_STATE;

 >  	priv->mcast_mtu = ib_mtu_enum_to_int(priv->broadcast->mcmember.mtu) -
 > -		IPOIB_ENCAP_LEN;
 > +			  IPOIB_ENCAP_LEN;

and so on.  Can you separate that into another patch, so that it's
easier to review the real changes here?

Thanks,
  Roland



More information about the general mailing list