[openib-general] Re: [RFC] [PATCH 1/2] multicast support for multiple users

Hal Rosenstock halr at voltaire.com
Thu Apr 6 13:07:42 PDT 2006


On Thu, 2006-04-06 at 15:51, Roland Dreier wrote:
>  > +	dev = kmalloc(sizeof *dev + device->phys_port_cnt * sizeof *port,
>  > +		      GFP_KERNEL);
>  > +	if (!dev)
>  > +		return;
>  > +
>  > +	for (i = 1; i <= device->phys_port_cnt; i++) {
> 
> Seems like this is implicitly assuming that the IB device is a CA.
> 
> Maybe we should give up the ghost and stop trying to support IB switches?

I would prefer not to. SMI changes for switches have been provided but
not integrated as yet. Enhanced switch port 0 would need this (at a
minimum).

-- Hal




More information about the general mailing list