[openib-general] Re: RFC: revert module ref counting patches

Sean Hefty mshefty at ichips.intel.com
Mon Apr 10 11:01:02 PDT 2006


Michael S. Tsirkin wrote:
> And now ib_sa can just
> 
> 	module_mutex_lock()
> 	query->callback(..)
> 	module_mutex_unlock()
> 
> to prevent modules from unloading while callback is in progress.
> 
> Same for other modules that use callbacks without registration, like ib_addr.

This seems like too broad of a fix.  We should just make sure that the module 
we're calling does not unload, rather than preventing any module from unloading. 
  Wouldn't this also serialize all callbacks?

- Sean



More information about the general mailing list