[openib-general] Fix for ibping

Hal Rosenstock halr at voltaire.com
Wed Apr 12 18:36:01 PDT 2006


On Wed, 2006-04-12 at 21:07, Viswanath Krishnamurthy wrote: 
> The mad_register_agent function in mad.c kernel file was checking for
> rmpp_version.
> This was failing and this failure was propagated to umad (thru ioctl)

Right. Just because a class is allowed to use RMPP doesn't mean that
rmpp_version needs to be set for the MAD agent to register. This was a
recent change which was too pedantic. I fixed this in r6448 so you can
revert the ibping change you sent and it should work now as before.
Thanks.

-- Hal

> 
> On 12 Apr 2006 20:46:33 -0400, Hal Rosenstock <halr at voltaire.com>
> wrote: 
>         On Wed, 2006-04-12 at 18:25, Viswanath Krishnamurthy wrote:
>         > The RMPP version needs to be 1.
>         
>         Thanks. I'm not sure what changed here to require this. I need
>         to do
>         some more digging.
>         
>         -- Hal
>         
>         > [ root at subnetmgr5 src]# svn diff ibping.c
>         > Index: ibping.c
>         >
>         ===================================================================
>         > -- ibping.c    (revision 6446)
>         > +++ ibping.c    (working copy)
>         > @@ -336,7 +336,7 @@
>         >                 exit(0);
>         >         }
>         >
>         > -       if (mad_register_client(ping_class, 0) < 0)
>         > +       if (mad_register_client(ping_class, 1) < 0)
>         >                 IBERROR("can't register to ping class %d",
>         > ping_class);
>         >
>         >         if (ib_resolve_portid_str(&portid, argv[0],
>         dest_type, sm_id)
>         > < 0)
>         >
>         >
>         >
>         >
>         ______________________________________________________________________ 
>         >
>         > _______________________________________________
>         > openib-general mailing list
>         > openib-general at openib.org
>         > http://openib.org/mailman/listinfo/openib-general
>         >
>         > To unsubscribe, please visit
>         http://openib.org/mailman/listinfo/openib-general
>         
> 




More information about the general mailing list