[openib-general][patch review] srp: fmr implementation,

[Vu Pham]

Roland Dreier wrote:
> Hmm, I don't understand what could be going on.  srp_send_tsk_mgmt()
> currently has:
> 
> 	if (req->cmd_done) {
> 		srp_remove_req(target, req, req_index);
> 		scmnd->scsi_done(scmnd);
> 	} else if (!req->tsk_status) {
> 		srp_remove_req(target, req, req_index);
> 		scmnd->result = DID_ABORT << 16;
> 		ret = SUCCESS;
> 	}
> 
> and otherwise it returns FAILED.  So in both cases where it finishes
> the command, it removes it from the list of pending requests.

The return happened before reaching the code above. It 
happened at:
	if (!wait_for_completion_timeout(&req->done,
					 msecs_to_jiffies(SRP_ABORT_TIMEOUT_MS)))
		return FAILED;

because the qp was in fatal state. Therefore, the command 
was not finished or removed from the pending queue

Vu