[openib-general] Re: [PATCH] RDMA CM: assign port numbers when binding a cm_id to an address

[Tom Tucker]

On Thu, 2006-04-20 at 19:17 +0300, Michael S. Tsirkin wrote:
> Quoting r. Sean Hefty <sean.hefty at intel.com>:
> > Subject: [PATCH] RDMA CM: assign port numbers when binding a cm_id to an address
> > 
> > Assign/reserve a port number when binding a cm_id.  If no port number is
> > given, assign one from the local port space.  If a port number is given,
> > reserve it.
> > 
> > The RDMA port space is separate from that used for TCP.  iWarp devices
> > will need to coordinate between the port values assigned by the rdma_cm
> > and those in use by TCP.  SDP also has its own port space.
> 
> So far, seems to work fine, here. I suggest you check it in to svn.
> 
> One small note: ipv4 on linux does this:
>         err = -EACCES;
>         if (snum && snum < PROT_SOCK && !capable(CAP_NET_BIND_SERVICE))
>                 goto out;
> 
> disabling bind to ports 1-1023 for non-priveledged users.

In my opinion it belongs in the CMA for consistency across all
transports. Note that the global port range variable is used to
determine where to start ephemeral port allocation.
 

> 
> Do you want to add such a check in CMA, or does it belong in SDP in your
> opinion?
>