[openib-general][patch review] srp: fmr implementation,

[Vu Pham]

Hi Roland,

> 
> I reported the error from my original email responding to your fmr 
> patch. For ia64 system with pcix hca I got asyn event 
> IB_EVENT_QP_ACCESS_ERR at the initiator (and I got cqe with 
> IB_COMPLETION_STATUS_REMOTE_ACCESS_ERROR status at my target)
> I still have not had an IB analyzer trace (as you suggested)

I still have not had the IB trace yet.

> 
>>
>> So the SCSI midlayer times out commands and tries to abort them.  But
>> we have no connection so the abort fails.  The SCSI command shouldn't
>> get freed now (at least if I'm understanding scsi_error.c correctly).
>>
>> Then we have no .eh_device_reset_handler so everything should fall
>> through to calling our .eh_host_reset_handler without freeing any SCSI
>> commands.  And then we crash on a use-after-free of a SCSI command.
>>
>> So where is that command getting freed on us??
>>
> 
> The scsi command that is used by error handlers (.eh_abort_handler, 
> .eh_host_reset_handler...) is not the same as use-after-free scsi 
> command from req->scmnd
> 
> There is some glitch that the scsi command from req->scmnd already freed 
> by scsi midlayer; however, the request is still in our pending request 
> queue

With the following patch applied my ia64 system does not crash anymore

I prepare this patch diffing from srp revision 6455 applied with 
srp-params.patch that I sent you last week

Please let me know if you want this patch generated from current srp 
(revision 6550)

What is the status for srp-params.patch (introducing tuned parameters)

Thanks,
Vu


-------------- next part --------------
A non-text attachment was scrubbed...
Name: srp_eh.patch
Type: text/x-patch
Size: 1673 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20060421/0b850167/attachment.bin>