[openib-general] [PATCH 1 of 2] core extensions to fix race at module unloading

Michael S. Tsirkin mst at mellanox.co.il
Sat Apr 22 11:21:54 PDT 2006


Quoting r. Sean Hefty <mshefty at ichips.intel.com>:
> Subject: Re: [openib-general] [PATCH 1 of 2] core extensions to fix race at module unloading
> 
> Michael S. Tsirkin wrote:
> > /**
> >+ * ib_flush_mad_agent - flush any callbacks in flight for this client.
> >+ * @mad_agent: Corresponding MAD registration request to flush.
> >+ */
> >+int ib_flush_mad_agent(struct ib_mad_agent *mad_agent);
> 
> To restate what I've mentioned before, I don't see any issue with the 
> ib_mad interface.  It doesn't make sense to me to change this API, when the 
> problem is in the client.  But I'd like to hear what others think.

The API is there to be used, no? If its useful for clients to flush
callbacks, why shouldn't ib_mad povide the service?
the implementation is trivial.

-- 
MST



More information about the general mailing list