[openib-general] Re: [PATCH] osm_sa_mcmember_record : MCMember Get/GetTable Trusted mode
Hal Rosenstock
halr at voltaire.com
Wed Apr 26 04:15:21 PDT 2006
Hi Ofer,
On Wed, 2006-04-26 at 05:29, Ofer Gigi wrote:
> Hi Hal,
> Small minor chnages:
Subject is inconsistent with the patch below.
> 1. Adding () for the if statement
Those extra parentheses shouldn't be needed as && is lower precedence
than ==.
> 2. Clearer messages when duplicate guids are found
Should Fatal be FATAL so it really stands out ?
I applied the second portion of this patch with some cosmetic changes to
both the trunk and 1.0 branch.
-- Hal
> Thanks
>
> Ofer G.
>
> Signed-off-by: Ofer Gigi <oferg at mellanox.co.il>
More information about the general
mailing list