[openib-general] Re: [PATCH 05/16] ehca: InfiniBand query and multicast functionality

[Jörn Engel]

Some small stuff.

On Thu, 27 April 2006 12:48:29 +0200, Heiko J Schick wrote:
> 
> + *  This source code is distributed under a dual license of GPL v2.0 and 
> OpenIB

Line wrap.  You might want to check your mailer or switch to a
different one.

> +		return (-EINVAL);

Remove brackets.

> +	if (H_SUCCESS != hipz_rc) {

To frown upon reversed grammar, I tend.  Hard to understand, such code
is.

With a decent compiler, there is zero advantage to put the constant
first - assuming you don't ignore warnings.  But it makes the code
just as hard to read as the Yoda-speak above.

> +	return retcode;

People tend to use the shorter "ret" or "err".

Jörn

-- 
You can take my soul, but not my lack of enthusiasm.
-- Wally