[openib-general] [PATCH] rdma_cm: let SDP control the SDP version in the hello header

[Michael S. Tsirkin]

Quoting r. Sean Hefty <sean.hefty at intel.com>:
> @@ -1486,7 +1486,8 @@ static void cma_format_hdr(void *hdr, en
>  	switch (ps) {
>  	case RDMA_PS_SDP:
>  		sdp_hdr = hdr;
> -		sdp_hdr->sdp_version = SDP_VERSION;
> +		if (sdp_hdr->sdp_version != SDP_VERSION)
> +			return -EINVAL;
>  		sdp_set_ip_ver(sdp_hdr, 4);
>  		sdp_hdr->src_addr.ip4.addr = src4->sin_addr.s_addr;
>  		sdp_hdr->dst_addr.ip4.addr = dst4->sin_addr.s_addr;

BTW, a diagnostic message would be helpful here: this could only happen
as a result of a bug after all.

-- 
MST