[openib-general] Re: [PATCH 10/16] ehca: event queue

[Segher Boessenkool]

>> +	if (ret != H_SUCCESS) {
>
> Common convention is to return 0 on success and -ESOMETHING on eror.
> You might want to follow that and remove H_SUCCESS from the complete
> code.

This return code doesn't come from anywhere within the kernel, though.
If we change this, we should get rid of _every_ #define bladibla 0
Do we want that?  (I do ;-) )

>> +		if (!(vpage = ipz_qpageit_get_inc(&eq->ipz_queue))) {
>
> I personally despise assignments in conditionals.  Not sure if this is
> documented in CodingStyle, but IME most kernel hackers tend to dislike
> it as well.

In this case it's obvious; put it on a separate line.


Segher