[openib-general] Re: Re: [PATCH v2] mad: use GID/LID on requester sidewhen matching responses to requests

Michael S. Tsirkin mst at mellanox.co.il
Sat Apr 29 18:25:31 PDT 2006


Quoting r. Sean Hefty <sean.hefty at intel.com>:
> Subject: RE: Re: [PATCH v2] mad: use GID/LID on requester sidewhen matching responses to requests
> 
> >> >Check GID/LID for requester side when searching for request which matches
> >> >received response.  This, in order to guarantee uniqueness if use same TID
> >> >when requesting via multiple source LIDs (when LMC is not zero). To perform
> >> >check, add LMC to cache.
> >> >
> >> >Further, do not perform LID check for direct-routed packets, since
> >> >permissive
> >> >LID makes a proper check impossible.
> >>
> >> Thanks - I'll look at this within the next couple of days.
> >
> >Could this patch be merged please? Sean?
> 
> There was a request to submit the LMC cache piece as a separate patch.  I can
> merge in the MAD changes after the LMC cache has been accepted.

Roland said:
"The lmc_cache stuff looks fine to me.

It probably would be better to commit it as a separate patch -- one
idea per patch."

so I understand he's fine with it, and the comment was with regard to
how to commit this - first core files, then MAD files.

Anyway, its trivial to split the patch, if you want help with that let me know.

-- 
MST



More information about the general mailing list