[openib-general] [PATCH v2 1/2] sa_query: add generic query interfaces capable of supporting RMPP

Sean Hefty mshefty at ichips.intel.com
Thu Aug 3 11:57:50 PDT 2006


Sean Hefty wrote:
> +int ib_sa_send_mad(struct ib_device *device, u8 port_num,
> +		   int method, void *attr, int attr_id,
> +		   ib_sa_comp_mask comp_mask,
> +		   int timeout_ms, int retries, gfp_t gfp_mask,
> +		   void (*callback)(int status,
> +				    struct ib_mad_recv_wc *mad_recv_wc,
> +				    void *context),
> +		   void *context, struct ib_sa_query **query);

Now that I've just updated and posted this...

I think it makes sense for this call to take a packed attribute as input, versus 
an unpacked one.  Attr_id can then be passed in as be16, which lets this 
interface, the callback, and it_sa_iter calls all deal with data in wire format.

My longer term intent is to create a libibsa to support easier userspace SA 
interactions.  It may be easier to handle packing / unpacking of attributes from 
userspace.  Comments?

- Sean




More information about the general mailing list