[openib-general] Fwd: issues in ipoib

[Michael S. Tsirkin]

Quoting r. Sean Hefty <sean.hefty at intel.com>:
> Subject: RE: Fwd: issues in ipoib
> 
> > static void ib_sa_path_rec_callback(struct ib_sa_query *sa_query,
> > 				    int status,
> > 				    struct ib_sa_mad *mad)
> >@@ -539,6 +551,7 @@ static void ib_sa_path_rec_callback(stru
> > 	struct ib_sa_path_query *query =
> > 		container_of(sa_query, struct ib_sa_path_query, sa_query);
> >
> >+	ib_sa_client_get(sa_query->client);
> 
> It makes more sense to me to increment the reference count when the query is
> initiated.

We can do that, I don't have a strong opinion either way.
Roland?

> We don't know that sa_query->client is still valid here unless a
> reference was taken earlier.

Yes we do.
Client must wait till all queries complete before unregistering.

> I like this approach, but would like to see it expanded to track the requests,
> to avoid duplicating this work in every client.  Unregistration would then
> cancel all outstanding queries issued by the user.

I would not object to this on principle, but let's go there by small
steps - for now, let's get the API fixed and  solve the race with module
unloading that we have for 2.6.18. OK?

-- 
MST