[openib-general] [PATCH] osm ib_types: remove CM defines
Sean Hefty
sean.hefty at intel.com
Tue Aug 8 11:38:36 PDT 2006
>As there may be other (unknown to me) applications using this, I do not
>feel comfortable with this. What might work is the following (untested)
>patch. Another approach might be to guard those defines in ib_types.h
>with CM_H.
The problem is that ib_types.h #define's these values before cm.h is included.
The defined values result in the enum in cm.h appearing as:
enum {
0,
1,
2,
3, ...
};
which doesn't compile.
If we need to rename the #define's in ib_types.h, then it makes more sense to me
to remove them completely. Both require changes to users, but the latter is
limited to a new include. A different approach would be to change ib_types.h to
use an identical enum.
- Sean
More information about the general
mailing list