[openib-general] [PATCH] osm: Dynamic verbosity control per file

[Hal Rosenstock]

Hi Yevgeny,

On Sun, 2006-08-13 at 15:16, Yevgeny Kliteynik wrote:
> Hi Hal.
> 
> > Is it hard to find which file and line an opensm 
> > log message comes from
> > ? Is this functionality really needed ?
> 
> I'm guessing that your question refers to the second  
> bullet - logging source code filename and line number.
> 
> IMHO, this is a nice-to-have functionality - when 
> debugging the SM that runs with a high verbosity,
> the log has a lot of information, and it's much 
> easier to follow the SM flow when each message
> tells where exactly it came from.

OK. I'll work on adding it but may not get to it for another day or so
(so it won't be in OFED 1.1 rc2) and may have other comments on the
specifics of the patch.

-- Hal

> Regards,
>  
> Yevgeny Kliteynik
>  
> Mellanox Technologies LTD
> Tel: +972-4-909-7200 ext: 394
> Fax: +972-4-959-3245
> P.O. Box 586 Yokneam 20692 ISRAEL 
>  
> 
> -----Original Message-----
> From: openib-general-bounces at openib.org
> [mailto:openib-general-bounces at openib.org] On Behalf Of Hal Rosenstock
> Sent: Tuesday, August 08, 2006 11:50 PM
> To: Yevgeny Kliteynik
> Cc: OPENIB
> Subject: Re: [openib-general] [PATCH] osm: Dynamic verbosity control per
> file
> 
> Hi Yevgeny,
> 
> On Wed, 2006-08-02 at 11:16, Yevgeny Kliteynik wrote:
> > Hi Hal
> 
> Just got back from vacation and am in the process of catching up.
> 
> > This patch adds new verbosity functionality.
> 
> > 1. Verbosity configuration file
> > -------------------------------
> > 
> > The user is able to set verbosity level per source code file 
> > by supplying verbosity configuration file using the following
> > command line arguments:
> > 
> >       -b filename
> >       --verbosity_file filename
> > 
> > By default, the OSM will use the following file: /etc/opensmlog.conf 
> > Verbosity configuration file should contain zero or more lines of
> > the following pattern:
> > 
> >       filename verbosity_level
> > 
> > where 'filename' is the name of the source code file that the
> > 'verbosity_level' refers to, and the 'verbosity_level' itself 
> > should be specified as an integer number (decimal or hexadecimal).
> > 
> > One reserved filename is 'all' - it represents general verbosity
> > level, that is used for all the files that are not specified in
> > the verbosity configuration file. 
> > If 'all' is not specified, the verbosity level set in the
> > command line will be used instead.
> > Note: The 'all' file verbosity level will override any other
> > general level that was specified by the command line arguments. 
> > 
> > Sending a SIGHUP signal to the OSM will cause it to reload
> > the verbosity configuration file.
> > 
> > 
> > 2. Logging source code filename and line number
> > -----------------------------------------------
> > 
> > If command line option -S or --log_source_info is specified,
> > OSM will add source code filename and line number to every
> > log message that is written to the log file.
> > By default, the OSM will not log this additional info. 
> > 
> > 
> > Yevgeny
> 
> Is it hard to find which file and line an opensm log message comes from
> ? Is this functionality really needed ?
> 
> -- Hal
> 
> 
> 
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
> 
> To unsubscribe, please visit
> http://openib.org/mailman/listinfo/openib-general