[openib-general] [PATCH 1/7] IB/ipath - performance improvements via mmap of queues

[Ralph Campbell]

On Wed, 2006-08-16 at 13:56 -0700, Roland Dreier wrote:
>     ralphc> A #define won't help the plug-in know what parameters to
>     ralphc> pass, only a function name change will work if the
>     ralphc> semantics change.
> 
> I don't follow:
> 
> 	#ifdef OLD_FUNCTION_HAS_NEW_PARAMS
> 		old_function(new_params);
> 	#else
> 		old_function(old_params);
> 	#endif
> 
>  - R.

I thought your goal was to be able to have one binary libipathverbs
or libmthca which could be dlopen()'ed by libibverbs.so.1.0 or
libibverbs.so.2.0. The dlopen()'ed library needs to dynamically
check which libibverbs opened it and call old_function() with
the appropriate arguments. If it is compiled in, it will be wrong
for the other case.

Was I misunderstanding your goal? The above works if you are only
trying to have one source code which can be compiled to work with
either version of libibverbs.