[openib-general] [PATCH 02/13] IB/ehca: includes

[Arnd Bergmann]

On Thursday 17 August 2006 22:11, Roland Dreier wrote:
> + * IS_EDEB_ON - Checks if debug is on for the given level.
> + */
> +#define IS_EDEB_ON(level) \
> +((ehca_edeb_filter(level, EDEB_ID_TO_U32(DEB_PREFIX), __LINE__) & \
> +  0x100000000L) == 0)
> +
> +#define EDEB_P_GENERIC(level,idstring,format,args...) \
> +do { \
> +       u64 ehca_edeb_filterresult =                                    \
> +               ehca_edeb_filter(level, EDEB_ID_TO_U32(DEB_PREFIX), __LINE__);\
> +       if ((ehca_edeb_filterresult & 0x100000000L) == 0)               \
> +               printk("PU%04x %08x:%s " idstring " "format "\n",       \
> +                      get_paca()->paca_index, (u32)(ehca_edeb_filterresult), \
> +                      __func__,  ##args);                              \
> +} while (1 == 0)

These macros are responsible for 61% of the object code size of your module.
This is completely insane. Please get rid of that crap entirely and replace
it with dev_info/dev_dbg/dev_warn calls where appropriate!

	Arnd <><