[openib-general] [PATCH] opensm: option to limit size of OpenSM log file

Sasha Khapyorsky sashak at voltaire.com
Tue Aug 22 15:22:30 PDT 2006


On 17:54 Tue 22 Aug     , Hal Rosenstock wrote:
> Hi Sasha,
> 
> On Tue, 2006-08-22 at 17:18, Sasha Khapyorsky wrote:
> > Hi Hal,
> > 
> > There is new option which specified max size of OpenSM log file. The
> > default is '0' (not-limited). Please note osm_log_init() has new
> > parameter now.
> 
> So libopensm.ver needs to be bumped (and this is not backward
> compatible).

We may. I'm not sure it is necessary - in this patch I've changed all
occurrences of osm_log_init() under osm/ (in opensm and osmtest). So
this can be important only if there are osm_log "external" users.

> 
> > We already saw the problems with FS overflowing in real life - we may
> > want those related fixes in OFED too.
> 
> Yes, I think this is appropriate for both the trunk and OFED 1.1.
> 
> > Sasha
> > 
> > 
> > opensm: option to limit size of OpenSM log file
> > 
> > New option '-L' will limit size of OpenSM log file. If specified the log
> > file will be truncated upon reaching this limit.
> > 
> > Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> > ---
> > 
> >  osm/complib/cl_event_wheel.c    |    2 
> >  osm/include/opensm/osm_log.h    |   44 +----------
> >  osm/include/opensm/osm_subnet.h |    6 +
> >  osm/opensm/libopensm.map        |    1 
> >  osm/opensm/main.c               |   13 +++
> >  osm/opensm/osm_log.c            |  163 ++++++++++++++++++++++++++-------------
> >  osm/opensm/osm_opensm.c         |    3 -
> >  osm/opensm/osm_subnet.c         |    9 ++
> >  osm/osmtest/osmtest.c           |    2 
> >  9 files changed, 143 insertions(+), 100 deletions(-)
> 
> I will make the requisite change to the man page when the time comes for
> this.

Great. Thanks.

Sasha

> 
> -- Hal
> 
> [snip...]
> 
> 




More information about the general mailing list