[openib-general] [PATCH] mthca: various bug fixes for mthca_query_qp
Roland Dreier
rdreier at cisco.com
Wed Aug 23 13:25:53 PDT 2006
> 5. Return the send_cq, receive cq and srq handles. ib_query_qp() needs them
> (required by IB Spec). ibv_query_qp() overwrites these values in user-space
> with appropriate user-space values.
> + qp_init_attr->send_cq = ibqp->send_cq;
> + qp_init_attr->recv_cq = ibqp->recv_cq;
> + qp_init_attr->srq = ibqp->srq;
I really disagree with this change. It's silly to do this copying
since the consumer already has the ibqp pointer. And it's especially
silly to put this in a low-level driver, since there's nothing
device-specific about it.
- R.
More information about the general
mailing list