[openib-general] [PATCH] mthca: various bug fixes for mthca_query_qp
Michael S. Tsirkin
mst at mellanox.co.il
Wed Aug 23 14:47:30 PDT 2006
Quoting r. Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH] mthca: various bug fixes for mthca_query_qp
>
> Michael> The other four bullets make sense however, do they not?
>
> I guess so, although I wonder if anyone will ever care about the
> sq_sig_type() field.
It's not in IB spec query QP, so that might be unlikely.
However, libibverbs seems to be looking at this field:
init_attr->sq_sig_all = resp.sq_sig_all;
so it only seems consistent to fill this in.
What do you think? Maybe its better to remove it from libibverbs?
What about other stuff?
--
MST
More information about the general
mailing list