[openib-general] [PATCH] osm: handle local events

[Sasha Khapyorsky]

On 16:28 Thu 24 Aug     , Michael S. Tsirkin wrote:
> Quoting r. Yevgeny Kliteynik <kliteyn at mellanox.co.il>:
> > Index: libvendor/osm_vendor_ibumad.c
> > ===================================================================
> > --- libvendor/osm_vendor_ibumad.c	(revision 8998)
> > +++ libvendor/osm_vendor_ibumad.c	(working copy)
> > @@ -72,6 +72,7 @@
> >  #include <opensm/osm_log.h>
> >  #include <opensm/osm_mad_pool.h>
> >  #include <vendor/osm_vendor_api.h>
> > +#include <infiniband/verbs.h>
> >  
> >  /****s* OpenSM: Vendor AL/osm_umad_bind_info_t
> >   * NAME
> 
> NAK.
> 
> This means that the SM becomes dependent on the uverbs module.  I don't think
> this is a good idea.  Let's not go there - SM should depend just on the umad
> module and libc.

Agree on this point. I dislike this new libibverbs dependency too. I
think we need to work with umad.

So more generic question: some application performs blocked read() from
/dev/umadN, should this read() be interrupted and return error (with
appropriate errno value), then the port state becomes DOWN?

I think yes, it should. Other opinions? Sean?

And if yes, then in OpenSM we will need just to check errno value upon
umad_recv() failure.

Sasha

>  In particular, SM should work even on embedded platforms where
> uverbs do not necessarily work.
> 
> Further, hotplug events still do not seem to be handled, even with this patch.
> 
> For port events, it seems sane that umad module could provide a way
> to listen for them.
> 
> A recent patch to mthca converts fatal events to hotplug events, so fatal events
> can and should be handled as part of general hotplug support.
> 
> -- 
> MST
> 
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>